Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly version numbers have reverted to default 1.0.0.0 ever since NuGet version 5.0.0-alpha-002 #521

Closed
DalekBaldwin opened this issue Aug 27, 2022 · 6 comments · Fixed by #629

Comments

@DalekBaldwin
Copy link

I haven't noticed this causing any build issues yet, but it is tripping up some other development tools.

@64J0
Copy link
Member

64J0 commented Apr 25, 2024

Hi @DalekBaldwin, thanks for opening this issue. Do you know if it's still happening nowadays?

@DalekBaldwin
Copy link
Author

Yes, it's still happening. You can inspect the metadata from here: https://nuget.info/packages/Giraffe/6.4.0

@64J0
Copy link
Member

64J0 commented Oct 8, 2024

I noticed that this happens for other projects from the F# community as well. For example SQLProvider:

image

The fix is apparently to have this AssemblyInfo file defining the values. I found it on Fable too.

Also related: dotnet/fsharp#5309 (comment)

@64J0 64J0 added the help wanted Community contribution or any kind of help much appreciated label Oct 8, 2024
@baronfel
Copy link
Contributor

baronfel commented Oct 8, 2024

Yous shouldn't need a dedicated assembly info file FYI - merely setting the Version property in your project file is enough to ensure that all of the relevant versioning data is stamped into your assembly.

@nojaf
Copy link
Contributor

nojaf commented Oct 9, 2024

Or use https://github.com/ionide/KeepAChangelog

@64J0
Copy link
Member

64J0 commented Nov 7, 2024

@64J0 64J0 closed this as completed in #629 Nov 22, 2024
@64J0 64J0 removed the help wanted Community contribution or any kind of help much appreciated label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants