Update example to output a single line on PHP 7.2 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere in the development leading up to PHP 7.2, var_dump() started outputting the file and line number as part of it's output. This causes one of the end-to-end tests to fail as the example script it uses outputs twice as many lines as expected. This fixes this by using var_export() and a little wrapping to output useful debug data if something goes wrong and sensible output otherwise.
|
Failures are on HHVM and seem unrelated to my changes. You should probably consider enabling PHP 7.2 builds on Travis. |
giorgiosironi
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere in the development leading up to PHP 7.2,
var_dump()started outputting the file and line number as part of it's output. This causes one of the end-to-end tests to fail as the example script it uses outputs twice as many lines as expected.This fixes this by using
var_export()and a little wrapping to output useful debug data if something goes wrong and sensible output otherwise.