Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cell::set_symbol for better heap handling #51

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Use Cell::set_symbol for better heap handling #51

merged 1 commit into from
Nov 6, 2023

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 6, 2023

tui-logger directly replaces symbol field of Cell. However there is more efficient API Cell::set_symbol. This method reuses the heap buffer in String so reallocation doesn't happen.

@gin66 gin66 merged commit c4a9a95 into gin66:master Nov 6, 2023
1 check passed
@rhysd rhysd mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysd @gin66