Update to angular 14 and fix angular breaking changes #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this pull request, it looks great, just have to make some tests and I will publish it. |
|
Sounds great! Let me know if you need anything else from me ;) |
|
Hi @gilsdav, did you find any issue with the pull request preventing it to be merged? If you found any issue but you don’t have time to investigate more or fix it, I can have a look to it 🧐 |
|
Hello @ruizmarc, sorry I'm out of my country but I will pass it monday at night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've just updated everything to Angular 14 and fixed all breaking changes.
I've tested the project with the demo project in the repo and my own project. Everything seems to work fine :)
Hope you can merge it!
PS: As there are breaking changes in angular router, this version cannot be backwards compatible with Angular 13 or previous. Anyone using Angular 13 should stick to localize router 4.