Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create compact 'vertical' display mode #41

Closed
fbegue opened this issue Nov 26, 2020 · 4 comments
Closed

create compact 'vertical' display mode #41

fbegue opened this issue Nov 26, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@fbegue
Copy link

fbegue commented Nov 26, 2020

First off - this is AMAZING thank you so much for providing this for the community!

I'm looking at trying to fit the player into a side panel on my website, so it would look more like this:

player_preview

From pulling down the repo and perusing, looks like I need to modify the Info component and then move it so it's above the Slider component in the index.tsx render. I would attempt this myself but thought:

  1. maybe this was already an enhancement that you were thinking about
  2. I can't build (Invalid switch - "*". while cleaning? I didn't try super hard diagnose - probably my fault)
  3. I am a junior dev and this looks . . like a professional made it. not like my projects :)

Anyways just wanted to get your input before looking into this anymore.

Thanks again!

@gilbarbara
Copy link
Owner

hey @fbegue

Thanks! 👍

Yeah, I'm already working on a UI update and I'll probably add a "compact" layout alongside themes.
Not sure about ETA yet, but soon.

Compact

compact

Inline (large screens)

inline-desktop

Inline (mobile)

inline-mobile

@fbegue
Copy link
Author

fbegue commented Sep 22, 2021

@gilbarbara any update on this? I'm working on mobile now and running out of space!

Although as it is, your player works great as a 'slide in from the top/bottom of the screen' dealio with React Spring 👍

@robksawyer
Copy link

Loving the module! It's looking great.

@gilbarbara gilbarbara changed the title thinking about branching to create compact 'vertical' display mode create compact 'vertical' display mode Oct 18, 2021
@gilbarbara
Copy link
Owner

Implemented in 0.12.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants