Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highliting the targeting element is not correct #548

Closed
julia-dizhak opened this issue Sep 16, 2019 · 3 comments
Closed

Highliting the targeting element is not correct #548

julia-dizhak opened this issue Sep 16, 2019 · 3 comments

Comments

@julia-dizhak
Copy link

julia-dizhak commented Sep 16, 2019

🐛 Bug Report

attached screenshot https://bit.ly/2kjR8JM
The target element is not correct.
After hovering on the element, highlighting will be set to correct element
version is "react-joyride": "2.0.0-15"

To Reproduce

Probably it's not happening consistently, only if you need to scroll to a target element in DOM.

Expected behavior

correct highlighting of the element

@gilbarbara
Copy link
Owner

It's impossible to debug without a live example...
Update to the latest version (2.1.1) and provide a working setup with the bug

@julia-dizhak
Copy link
Author

Hi

To be honest, with version 2.1.1 the behavior even worst.

Yes, it impossible to debug without a live example. But the problem that it's difficult to provide actually playground because of it's highly specific. Like we have kind of chat where messages appear with an infinite scroll.
Veezoo

In a final decision, we used smoothscroll polyfill to be able to scroll to the correct target element and positions for spotlights

const element = document.querySelector(tour.step.target);
element.scrollIntoView({
    block: 'center' 
});

And thanks for your quick response.

@ekfuhrmann
Copy link

I was having an issue with the spotlight being offset when the user had scrolled slightly down the page. It ended up being that I had height: 100% on my html element and that was throwing off the auto scroller and by extension the spotlight positioning. Removing height: 100% in my case resolved the issue and might be worth trying for those who run into a similar problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants