Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Set options.flavor in _rollActionData #54

Open
tposney opened this issue Aug 17, 2021 · 0 comments
Open

Feature Request: Set options.flavor in _rollActionData #54

tposney opened this issue Aug 17, 2021 · 0 comments

Comments

@tposney
Copy link

tposney commented Aug 17, 2021

Hey, nice module and looks good (although blue is not my favourite colour :))

I've had a query about midi-qol compatibility and had a look. There is a midi-qol "feature" that when it applies damage/creates a damage card it steps through each of the damage lines in an item to work out what the final roll terms are and the damage type - which does not work for specs like [damage, d6].

That's not an issue since there is fall back processing to look at the actual roll terms to get the damage type from options.flavor (i.e. for Other/Versatile damage rolls).

So, the feature request is to make the damage terms look like Xd6[piercing] or whatever damage type is appropriate in _rollActionDamage when constructing the roll parts OR to set options.flavor in the roll results.

Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant