Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix private endpoint deletion in CAPZ #2528

Closed
2 of 4 tasks
Tracked by #2012
nprokopic opened this issue Jun 5, 2023 · 1 comment
Closed
2 of 4 tasks
Tracked by #2012

Fix private endpoint deletion in CAPZ #2528

nprokopic opened this issue Jun 5, 2023 · 1 comment
Assignees
Labels
kind/bug provider/cluster-api-azure Cluster API based running on Azure team/turtles Team Turtles

Comments

@nprokopic
Copy link

nprokopic commented Jun 5, 2023

Motivation

Private endpoint deletion in CAPZ is broken (or the deletion implementation is incomplete). When a private endpoint is deleted in AzureCluster CR, the private endpoint resource in Azure is not deleted.

TODO

  • When a private endpoint is deleted in AzureCluster CR, delete that private endpoint resource in Azure.
  • Test the outcome. Write needed unit/integration tests in CAPZ, verify in Giant Swarm test clusters.
  • Check with CAPZ community if this fix should be contributed to CAPZ upstream, considering that private endpoint implementation will soon switch to use ASO.
  • Communicate to Team Phoenix if the fix will be contributed to upstream or not, and explain the reasoning.

Outcome

  • When a private endpoint is deleted in AzureCluster CR, the private endpoint resource is deleted in Azure.
@nprokopic
Copy link
Author

Fixed here giantswarm/cluster-api-provider-azure#19.

We don't want to contribute this to upstream CAPZ, as CAPZ will start using azure-service-operator which will change the underlying implementation, which would make our fix obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug provider/cluster-api-azure Cluster API based running on Azure team/turtles Team Turtles
Projects
None yet
Development

No branches or pull requests

3 participants