From acee1bf026819e6bad65a5d108f2c59ac6c2dc29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Herv=C3=A9=20Nicol?= Date: Tue, 12 Mar 2024 11:17:21 +0100 Subject: [PATCH] Set PromtailDown alert to not page out of business hours (#1068) * Set PromtailDown alert to not page out of business hours --------- Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com> --- CHANGELOG.md | 4 ++++ .../templates/alerting-rules/promtail.rules.yml | 1 + test/tests/providers/global/promtail.rules.test.yml | 3 +++ 3 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8169bd851..6805626f3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Changed + +- Set `PromtailDown` alert to not page out of business hours + ## [3.0.2] - 2024-03-12 ### Fixed diff --git a/helm/prometheus-rules/templates/alerting-rules/promtail.rules.yml b/helm/prometheus-rules/templates/alerting-rules/promtail.rules.yml index f11abe93b..e29bab951 100644 --- a/helm/prometheus-rules/templates/alerting-rules/promtail.rules.yml +++ b/helm/prometheus-rules/templates/alerting-rules/promtail.rules.yml @@ -20,6 +20,7 @@ spec: severity: page team: "atlas" topic: "observability" + cancel_if_outside_working_hours: "true" cancel_if_cluster_status_creating: "true" cancel_if_cluster_status_deleting: "true" cancel_if_cluster_status_updating: "true" diff --git a/test/tests/providers/global/promtail.rules.test.yml b/test/tests/providers/global/promtail.rules.test.yml index 724a4b6a7..cc6a2efcc 100644 --- a/test/tests/providers/global/promtail.rules.test.yml +++ b/test/tests/providers/global/promtail.rules.test.yml @@ -23,6 +23,7 @@ tests: exp_alerts: - exp_labels: area: empowerment + cancel_if_outside_working_hours: "true" cancel_if_cluster_status_creating: "true" cancel_if_cluster_status_deleting: "true" cancel_if_cluster_status_updating: "true" @@ -39,6 +40,7 @@ tests: exp_alerts: - exp_labels: area: empowerment + cancel_if_outside_working_hours: "true" cancel_if_cluster_status_creating: "true" cancel_if_cluster_status_deleting: "true" cancel_if_cluster_status_updating: "true" @@ -56,6 +58,7 @@ tests: exp_alerts: - exp_labels: area: empowerment + cancel_if_outside_working_hours: "true" cancel_if_cluster_status_creating: "true" cancel_if_cluster_status_deleting: "true" cancel_if_cluster_status_updating: "true"