From 6b2b154d445bbd0bb36b3a9b3a8a4f666261e1c5 Mon Sep 17 00:00:00 2001
From: Lukasz Jakimczuk <39192420+ljakimczuk@users.noreply.github.com>
Date: Thu, 7 Nov 2024 10:37:20 +0100
Subject: [PATCH] Update app.rules.yml (#1418)

* Update app.rules.yml

* Fix tests?

* Changelog
---
 CHANGELOG.md                                                   | 1 +
 .../platform/honeybadger/alerting-rules/app.rules.yml          | 3 +++
 .../platform/honeybadger/alerting-rules/app.rules.test.yml     | 1 +
 3 files changed, 5 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 10e041512..292dd978e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 
 - Fixes the statefulset.rules name as it is currently replacing the deployment.rules alerts.
+- Extends AppCR-related alerts with cancelation for CAPI clusters with unavailable control plane.
 
 ## [4.22.0] - 2024-10-29
 
diff --git a/helm/prometheus-rules/templates/platform/honeybadger/alerting-rules/app.rules.yml b/helm/prometheus-rules/templates/platform/honeybadger/alerting-rules/app.rules.yml
index 33c535c1a..fac504908 100644
--- a/helm/prometheus-rules/templates/platform/honeybadger/alerting-rules/app.rules.yml
+++ b/helm/prometheus-rules/templates/platform/honeybadger/alerting-rules/app.rules.yml
@@ -21,6 +21,7 @@ spec:
       for: 30m
       labels:
         area: platform
+        cancel_if_cluster_control_plane_unhealthy: "true"
         cancel_if_cluster_status_creating: "true"
         cancel_if_cluster_status_deleting: "true"
         cancel_if_cluster_status_updating: "true"
@@ -55,6 +56,7 @@ spec:
       for: 30m
       labels:
         area: platform
+        cancel_if_cluster_control_plane_unhealthy: "true"
         cancel_if_cluster_status_creating: "true"
         cancel_if_cluster_status_deleting: "true"
         cancel_if_cluster_status_updating: "true"
@@ -75,6 +77,7 @@ spec:
       for: 30m
       labels:
         area: platform
+        cancel_if_cluster_control_plane_unhealthy: "true"
         cancel_if_cluster_status_creating: "true"
         cancel_if_cluster_status_deleting: "true"
         cancel_if_cluster_status_updating: "true"
diff --git a/test/tests/providers/global/platform/honeybadger/alerting-rules/app.rules.test.yml b/test/tests/providers/global/platform/honeybadger/alerting-rules/app.rules.test.yml
index 0c97be969..86aeb0052 100644
--- a/test/tests/providers/global/platform/honeybadger/alerting-rules/app.rules.test.yml
+++ b/test/tests/providers/global/platform/honeybadger/alerting-rules/app.rules.test.yml
@@ -17,6 +17,7 @@ tests:
               app: cilium
               app_version: 1.11.2
               area: platform
+              cancel_if_cluster_control_plane_unhealthy: "true"
               cancel_if_cluster_status_creating: "true"
               cancel_if_cluster_status_deleting: "true"
               cancel_if_cluster_status_updating: "true"