From 32d4a4d278f656b44f2199fcf46f9a706166dff2 Mon Sep 17 00:00:00 2001 From: Berk Dehrioglu Date: Tue, 7 May 2024 18:31:46 +0300 Subject: [PATCH] add annotation for gc to cleanup loadbalancers (#593) --- CHANGELOG.md | 4 ++++ helm/cluster-aws/templates/_aws_cluster.tpl | 1 + 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 58135a33..a93d474d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- Added an annotation to Kubernetes resources to resolve an issue where deletion was stuck due to hanging load balancers. + ### Added - Make Cilium ENI-based IP allocation configurable with high-level `global.connectivity.cilium.ipamMode` value. This feature was previously introduced as prototype and is now fully working. diff --git a/helm/cluster-aws/templates/_aws_cluster.tpl b/helm/cluster-aws/templates/_aws_cluster.tpl index 43da4579..c7751ab5 100644 --- a/helm/cluster-aws/templates/_aws_cluster.tpl +++ b/helm/cluster-aws/templates/_aws_cluster.tpl @@ -19,6 +19,7 @@ metadata: cluster.x-k8s.io/paused: "true" {{end}} aws.cluster.x-k8s.io/external-resource-gc: "true" + aws.cluster.x-k8s.io/external-resource-tasks-gc: "load-balancer,security-group" aws.giantswarm.io/vpc-endpoint-mode: "{{ .Values.global.connectivity.vpcEndpointMode }}" network-topology.giantswarm.io/mode: "{{ .Values.global.connectivity.topology.mode }}" {{- if .Values.global.connectivity.topology.transitGatewayId }}