This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Exclude default branch in some CircleCI workflows #3774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://github.com/giantswarm/giantswarm/issues/31824
This PR should exclude commits to the default branch from triggering the "push-to-registries" and "push-to-app-catalog" workflows. The assumption is that these workflows should be triggered only by pushes to non-default branches and by release tags.
The reason we are making this PR is that we have encountered problems with container image replication that are likely caused by fast pushes of the same image tag with different content. In addition, this will help us avoid obsolete CI runs.
As a code owner, please review and merge this PR if possible.
If you have reasons to keep these workflows running for the default branch, please let us (Honeybadger) know. Thank you!