Process get_memory_maps() raises RuntimeError on BSD

[giampaolo]

From g.rodola on April 11, 2013 15:32:09

>>> import psutil
>>> psutil.Process(1).get_memory_maps()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "psutil/__init__.py", line 655, in get_memory_maps
    it = self._platform_impl.get_memory_maps()
  File "psutil/_psbsd.py", line 152, in wrapper
    return fun(self, *args, **kwargs)
  File "psutil/_psbsd.py", line 338, in get_memory_maps
    return _psutil_bsd.get_process_memory_maps(self.pid)
RuntimeError: kinfo_getvmmap() failed

This happens for all low-pid processes.
Instead we should raise AccessDenied.

Original issue: http://code.google.com/p/psutil/issues/detail?id=366

[giampaolo]

From g.rodola on April 11, 2013 07:52:42

Actually it's not just get_memory_maps().
We also have:
- get_num_fds()
- get_open_files()
- getcwd()

All of them should raise AccessDenied.

    ======================================================================
    FAIL: test_get_memory_maps (proc=psutil.Process(pid=0, name='kernel'))
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "test/test_psutil.py", line 1717, in test_fetch_all
        ret = attr()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/__init__.py", line 
655, in get_memory_maps
        it = self._platform_impl.get_memory_maps()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 152, in wrapper
        return fun(self, *args, **kwargs)
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 338, 
in get_memory_maps
        return _psutil_bsd.get_process_memory_maps(self.pid)
    RuntimeError: kinfo_getvmmap() failed    

    ======================================================================
    FAIL: test_get_num_fds (proc=psutil.Process(pid=0, name='kernel'))
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "test/test_psutil.py", line 1717, in test_fetch_all
        ret = attr()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/__init__.py", line 
463, in get_num_fds
        return self._platform_impl.get_num_fds()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 152, in wrapper
        return fun(self, *args, **kwargs)
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 268, 
in get_num_fds
        return _psutil_bsd.get_process_num_fds(self.pid)
    SystemError: error return without exception set    

    ======================================================================
    FAIL: test_get_open_files (proc=psutil.Process(pid=0, name='kernel'))
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "test/test_psutil.py", line 1717, in test_fetch_all
        ret = attr()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/__init__.py", line 
675, in get_open_files
        return self._platform_impl.get_open_files()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 152, in wrapper
        return fun(self, *args, **kwargs)
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 286, 
in get_open_files
        rawlist = _psutil_bsd.get_process_open_files(self.pid)
    SystemError: error return without exception set    

    ======================================================================
    FAIL: test_getcwd (proc=psutil.Process(pid=0, name='kernel'))
    ----------------------------------------------------------------------
    Traceback (most recent call last):
      File "test/test_psutil.py", line 1717, in test_fetch_all
        ret = attr()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/__init__.py", line 
385, in getcwd
        return self._platform_impl.get_process_cwd()
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 152, in wrapper
        return fun(self, *args, **kwargs)
      File "build/bdist.freebsd-9.1-RC1-amd64/egg/psutil/_psbsd.py", line 218, 
in get_process_cwd
        return _psutil_bsd.get_process_cwd(self.pid) or None
    SystemError: error return without exception set

Labels: -Priority-Medium Priority-High

[giampaolo]

From g.rodola on April 11, 2013 15:43:33

Fixed in revision f976a68910c2 .

[giampaolo]

From g.rodola on April 11, 2013 15:43:42

Status: FixedInHG

[giampaolo]

From g.rodola on April 12, 2013 11:21:27

Status: Fixed