Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] 5.6.6 failing to build from PyPI source distribution #1630

Closed
jjhelmus opened this issue Nov 25, 2019 · 2 comments
Closed

[windows] 5.6.6 failing to build from PyPI source distribution #1630

jjhelmus opened this issue Nov 25, 2019 · 2 comments

Comments

@jjhelmus
Copy link

jjhelmus commented Nov 25, 2019

Platform

  • { windows }
  • { 5.6.6 }

Bug description

Attempting to build psutil from the source distribution if PyPI on Windows using python -m pip install --ignore-installed --no-deps . fails with the following:

C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\cl.exe /c /nologo /Ox /W3 /GL /DNDEBUG /MD -DPSUTIL_VERSION=566 -DPSUTIL_WINDOWS=1 -D_WIN32_WINNT=0x01000 -D_AVAIL_WINVER_=0x01000 -D_CRT_SECURE_NO_WARNINGS -DPSAPI_VERSION=1 -ID:\bld\psutil_1574688127695\_h_env\include -ID:\bld\psutil_1574688127695\_h_env\include "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE" "-IC:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE" "-IC:\Program Files (x86)…7763.0\um" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.17763.0\winrt" -ID:\bld\psutil_1574688127695\_h_env\Library\include -ID:\bld\psutil_1574688127695\_h_env\Library\include /Tcpsutil/_psutil_windows.c /Fobuild\temp.win-amd64-3.6\Release\psutil/_psutil_windows.obj
    _psutil_windows.c
    psutil/_psutil_windows.c(272): error C2094: label 'error' was undefined
    error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2

The changes to _psutil_windows.c made in 72c84cb and f7e898b do not look to be fully reverted in b2414b8 which leaves the error label undefined in the psutil_proc_kill function.

c.f. conda-forge/psutil-feedstock#43

@giampaolo
Copy link
Owner

FIxed and released a new version.

@jjhelmus
Copy link
Author

Thanks for the quick fix @giampaolo, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants