Fixes to net_connections() on FreeBSD. #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This not only removes ugly workaround from test_connections.py, but also fixes several failures in this test. Without file descriptor value, two local sockets connected to each other, would be equal objects. Since in the _psbsd.py:net_connections(), the returned value is a Python set, it will exclude any duplicates, resulting in shrinked list of sockets.
|
Amazing! I wouldn't have made it. This was a high-priority one and also a new feature was added (the fd). Thanks a lot Gleb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that the fd values were all initialized to -1, making pairs of locally connected sockets equal, thus truncated when added to Python set.