diff --git a/core/src/main/java/bisq/core/api/CoreApi.java b/core/src/main/java/bisq/core/api/CoreApi.java index 1f4d81a1eff..6c59bcdee16 100644 --- a/core/src/main/java/bisq/core/api/CoreApi.java +++ b/core/src/main/java/bisq/core/api/CoreApi.java @@ -18,9 +18,7 @@ package bisq.core.api; import bisq.core.api.model.AddressBalanceInfo; -import bisq.core.monetary.Price; import bisq.core.offer.Offer; -import bisq.core.offer.OfferPayload; import bisq.core.payment.PaymentAccount; import bisq.core.trade.handlers.TransactionResultHandler; import bisq.core.trade.statistics.TradeStatistics2; @@ -28,8 +26,6 @@ import bisq.common.app.Version; -import org.bitcoinj.core.Coin; - import javax.inject.Inject; import java.util.ArrayList; @@ -105,32 +101,6 @@ public void createOffer(String currencyCode, resultHandler); } - public void createOffer(String offerId, - String currencyCode, - OfferPayload.Direction direction, - Price price, - boolean useMarketBasedPrice, - double marketPriceMargin, - Coin amount, - Coin minAmount, - double buyerSecurityDeposit, - PaymentAccount paymentAccount, - boolean useSavingsWallet, - TransactionResultHandler resultHandler) { - coreOffersService.createOffer(offerId, - currencyCode, - direction, - price, - useMarketBasedPrice, - marketPriceMargin, - amount, - minAmount, - buyerSecurityDeposit, - paymentAccount, - useSavingsWallet, - resultHandler); - } - /////////////////////////////////////////////////////////////////////////////////////////// // PaymentAccounts /////////////////////////////////////////////////////////////////////////////////////////// diff --git a/daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java b/daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java index 8a3fa548d92..16ba5bbe3ca 100644 --- a/daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java +++ b/daemon/src/main/java/bisq/daemon/grpc/GrpcOffersService.java @@ -87,7 +87,7 @@ public void getOffers(GetOffersRequest req, public void createOffer(CreateOfferRequest req, StreamObserver responseObserver) { TransactionResultHandler resultHandler = transaction -> { - CreateOfferReply reply = CreateOfferReply.newBuilder().setResult(true).build(); + CreateOfferReply reply = CreateOfferReply.newBuilder().setId("todo").build(); responseObserver.onNext(reply); responseObserver.onCompleted(); }; diff --git a/proto/src/main/proto/grpc.proto b/proto/src/main/proto/grpc.proto index 6353be0c0b9..34f4c517ee1 100644 --- a/proto/src/main/proto/grpc.proto +++ b/proto/src/main/proto/grpc.proto @@ -76,7 +76,7 @@ message GetOffersReply { } message CreateOfferRequest { - string currencyCode = 1; // TODO switch order w/ direction field in next PR + string currencyCode = 1; string direction = 2; uint64 price = 3; bool useMarketBasedPrice = 4; @@ -88,7 +88,7 @@ message CreateOfferRequest { } message CreateOfferReply { - bool result = 1; + string id = 1; } message OfferInfo {