Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deprecation of InputValues #1848

Closed
brodin opened this issue Aug 22, 2023 · 2 comments · Fixed by #1932
Closed

Support deprecation of InputValues #1848

brodin opened this issue Aug 22, 2023 · 2 comments · Fixed by #1932
Labels
good first issue Good for newcomers server Issue related to caliban server spec Issue related to the graphql spec

Comments

@brodin
Copy link
Contributor

brodin commented Aug 22, 2023

The support for deprecation of input values was added to the spec about a year a ago (graphql/graphql-spec#805) would it be possible to modify InputValue.scala#L8-L12 in a way so that it also honours the deprecation decorator (GQLDeprecated)?
@ghostdogpr
Copy link
Owner

We usually work off the "released" spec (https://spec.graphql.org/) but for some features such as Defer or more recently the oneof directive, we add support earlier than that so I have no problem adding this one.

@ghostdogpr ghostdogpr added good first issue Good for newcomers server Issue related to caliban server core spec Issue related to the graphql spec labels Aug 23, 2023
@brodin
Copy link
Contributor Author

brodin commented Aug 23, 2023

Ah, my bad @ghostdogpr ! Did not know about the difference between "merged" and "released" for the spec!

Appreciate the flexibility thou 🙏

@ghostdogpr ghostdogpr mentioned this issue Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers server Issue related to caliban server spec Issue related to the graphql spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support deprecation of input values ghostdogpr/caliban
2 participants
@brodin @ghostdogpr