From d11f141250b9a6edd31f719a166f2726201efc7e Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Fri, 29 Dec 2023 15:06:48 -0500 Subject: [PATCH 1/2] fix: GroupingGetterFunction should return value Generic Type --- packages/common/src/interfaces/grouping.interface.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/interfaces/grouping.interface.ts b/packages/common/src/interfaces/grouping.interface.ts index 1d0069b40..8deda72fc 100644 --- a/packages/common/src/interfaces/grouping.interface.ts +++ b/packages/common/src/interfaces/grouping.interface.ts @@ -3,7 +3,7 @@ import type { GroupingComparerItem } from './groupingComparerItem.interface'; import type { GroupingFormatterItem } from './groupingFormatterItem.interface'; import type { SortDirectionNumber } from '../enums/sortDirectionNumber.enum'; -export type GroupingGetterFunction = (value: T) => string; +export type GroupingGetterFunction = (value: T) => T; export interface Grouping { /** Grouping Aggregators array */ From 22eb789502a3f9c164bbfcd6d3e63e5935519e3a Mon Sep 17 00:00:00 2001 From: ghiscoding Date: Fri, 29 Dec 2023 15:15:24 -0500 Subject: [PATCH 2/2] chore: GroupingGetterFunction should be allowed to return arbitrary value --- packages/common/src/interfaces/grouping.interface.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/common/src/interfaces/grouping.interface.ts b/packages/common/src/interfaces/grouping.interface.ts index 8deda72fc..4908ce14f 100644 --- a/packages/common/src/interfaces/grouping.interface.ts +++ b/packages/common/src/interfaces/grouping.interface.ts @@ -3,7 +3,7 @@ import type { GroupingComparerItem } from './groupingComparerItem.interface'; import type { GroupingFormatterItem } from './groupingFormatterItem.interface'; import type { SortDirectionNumber } from '../enums/sortDirectionNumber.enum'; -export type GroupingGetterFunction = (value: T) => T; +export type GroupingGetterFunction = (value: T) => any; export interface Grouping { /** Grouping Aggregators array */