From cb0297f62020095b475c9970239365512405a4f2 Mon Sep 17 00:00:00 2001
From: ghiscoding <Ghislain.Beaulac@se.com>
Date: Fri, 27 Oct 2023 15:52:25 -0400
Subject: [PATCH] =?UTF-8?q?fix(common):=20replace=20`innerHTML:=20'&times;?=
 =?UTF-8?q?'`=20with=20`textContent:=20'=C3=97'`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 packages/common/src/extensions/extensionCommonUtils.ts  | 2 +-
 packages/common/src/extensions/menuFromCellBaseClass.ts | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/common/src/extensions/extensionCommonUtils.ts b/packages/common/src/extensions/extensionCommonUtils.ts
index cacd4c7cb..d7a3ba863 100644
--- a/packages/common/src/extensions/extensionCommonUtils.ts
+++ b/packages/common/src/extensions/extensionCommonUtils.ts
@@ -12,7 +12,7 @@ export function addCloseButtomElement(this: SlickColumnPicker | SlickGridMenu, m
   const closePickerButtonElm = createDomElement('button', {
     type: 'button', className: 'close',
     ariaLabel: 'Close',
-    innerHTML: '&times;',
+    textContent: '×',
     dataset: { dismiss: context instanceof SlickColumnPicker ? 'slick-column-picker' : 'slick-grid-menu' }
   });
   menuElm.appendChild(closePickerButtonElm);
diff --git a/packages/common/src/extensions/menuFromCellBaseClass.ts b/packages/common/src/extensions/menuFromCellBaseClass.ts
index 691edfc67..c26a61924 100644
--- a/packages/common/src/extensions/menuFromCellBaseClass.ts
+++ b/packages/common/src/extensions/menuFromCellBaseClass.ts
@@ -155,7 +155,7 @@ export class MenuFromCellBaseClass<M extends CellMenu | ContextMenu> extends Men
       menuElm.style.width = findWidthOrDefault(this.addonOptions?.width);
     }
 
-    const closeButtonElm = createDomElement('button', { ariaLabel: 'Close', className: 'close', type: 'button', innerHTML: '&times;', dataset: { dismiss: this._menuCssPrefix } });
+    const closeButtonElm = createDomElement('button', { ariaLabel: 'Close', className: 'close', type: 'button', textContent: '×', dataset: { dismiss: this._menuCssPrefix } });
 
     // -- Option List section
     if (!(this.addonOptions as CellMenu | ContextMenu).hideOptionSection && isColumnOptionAllowed && optionItems.length > 0) {