Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add better aria accessibility missing on menus and checkboxes #968

Merged
merged 3 commits into from
May 8, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #968 (86c3587) into master (6601998) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #968   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16610     16620   +10     
  Branches      5905      5905           
=========================================
+ Hits         16610     16620   +10     
Impacted Files Coverage Δ
...ages/common/src/extensions/extensionCommonUtils.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/menuBaseClass.ts 100.00% <100.00%> (ø)
...ges/common/src/extensions/menuFromCellBaseClass.ts 100.00% <100.00%> (ø)
...common/src/extensions/slickCheckboxSelectColumn.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/slickColumnPicker.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickGridMenu.ts 100.00% <100.00%> (ø)
packages/common/src/extensions/slickHeaderMenu.ts 100.00% <100.00%> (ø)
...nation-component/src/slick-pagination.component.ts 100.00% <100.00%> (ø)

@ghiscoding ghiscoding merged commit 8041c11 into master May 8, 2023
@ghiscoding ghiscoding deleted the bugfix/menu-checkbox-accessibility branch May 8, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant