Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binding): remove unnecessary sanitizer in BindingService #947

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 6, 2023

  • we used DOM Purify in the Binding Service to sanitize variable binding values but it's most probably not needed at all and it was found to be a problem in Salesforce because DOM Purify doesn't work on that environment, so let's simplify the Binding Service

- we used DOM Purify in the BindingService to sanitize variable binding values but it's most probably not need and it was found to be a problem in Salesforce because DOM Purify doesn't work on that environment, so let's simplify the binding
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #947 (7c032bb) into master (4ea6071) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #947   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          244       244           
  Lines        16618     16613    -5     
  Branches      5915      5908    -7     
=========================================
- Hits         16618     16613    -5     
Impacted Files Coverage Δ
packages/binding/src/binding.helper.ts 100.00% <ø> (ø)
packages/binding/src/binding.service.ts 100.00% <100.00%> (ø)
...nation-component/src/slick-pagination.component.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 32a9a35 into master Apr 6, 2023
@ghiscoding ghiscoding deleted the bugfix/remove-sanitizer-on-binding branch April 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant