Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): disable browser autofill on the Editors.autocompleter #776

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 18, 2022

  • the browser autofill/autocomplete conflicts with the Editors.autocompleter and should be disabled

image

with the fix

image

- the browser autofill/autocomplete conflicts with the Editors.autocompleter and should be disabled
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #776 (bc0d634) into master (7d6d98a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #776   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          234       234           
  Lines        16378     16378           
  Branches      5498      5498           
=========================================
  Hits         16378     16378           
Impacted Files Coverage Δ
packages/common/src/editors/autocompleterEditor.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit fd2cf53 into master Oct 18, 2022
@ghiscoding ghiscoding deleted the bugfix/autocompleter-editor-autofill branch October 18, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant