partial translation with custom i18n namespase

[someusersomeuser]

Describe the bug

with custom namespace some items in menu not translated - duplicate namespace in key string

@slickgrid-universal\common\dist\esm\extensions\extensionUtility.js -> translateMenuItemsFromTitleKey(items)

this method add translationPrefix to item.titleKey before translate, but titleKey already contains translationPrefix:

@slickgrid-universal\common\dist\esm\extensions\slickGridMenu.js -> addGridMenuCustomCommands(originalCommandItems)

fix translateMenuItemsFromTitleKey to remove duplicate translationPrefix, or check, that the titleKey not already starts with translationPrefix

Reproduction

1. set gridOptions.translationNamespace = 'aurelia-slickgrid'
2. load i18n translations for grid to this namespace

Environment Info

aurelia 1
@slickgrid-universal/[email protected]
typescript none
browsers any
os any

Validations

• Follow our Code of Conduct
• Read the Wikis.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion.
• The provided reproduction is a minimal reproducible example of the bug.

[ghiscoding]

Pull Request are welcome if you think that you have a fix. I never used the prefix so I'm not the best person to look into this

[someusersomeuser]

simple way is check that translationPrefix already contains

but imho true way remove prefix from all *Menu sources, and save it in translateMenuItemsFromTitleKey.

what is your opinion?

[ghiscoding]

hmm I`m not sure that adding string check of the prefix for every single translation key is necessary a good thing. I would rather fix the source of the duplicate prefix. The thing is that as I said I never used it myself and the person who opened this issue in Aurelia-Slickgrid, which I've added the feature for him, never came back to me to confirm if it works as expected. So I'm not necessarily surprised about this new issue you opened, So I still think fixing the source is ideal

[someusersomeuser]

I checked the code history. I think previously it worked as expected.
this commit adds duplicate prefix feat(plugins): move external Header Menu into Slickgrid-Universal

my new idea - simply remove prefix from translateMenuItemsFromTitleKey

then internal keys still contains prefix, if it is set
and for custom menu items, user can add another namespace if needed, or use default namespace, or set the same prefix manually