Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exports): grid with colspan should export accordingly #311

Merged
merged 1 commit into from
Apr 16, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Apr 16, 2021

  • read each item metadata to evaluate if the row has any colspan defined and if so then export them accordingly (in Excel we would merge the cells but in regular text export then we would just return empty string)

TODOs

  • should work with Export to Excel
    • with Excel we should merge cells as per the colspan defined
  • should work with Export to Text File
    • with Text Export, we should blank any cell not being the first colspan cell
  • add full unit test suite coverage

- read each item metadata to evaluate if the row has any colspan defined and if so then export them accordingly (in Excel we would merge the cells but in regular text export then we would just return empty string)
@ghiscoding ghiscoding changed the title fix(exports): grid with colspan should be export accordingly fix(exports): grid with colspan should be exported accordingly Apr 16, 2021
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #311 (cf96197) into master (09a4cd3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        12724     12765   +41     
  Branches      4350      4368   +18     
=========================================
+ Hits         12724     12765   +41     
Impacted Files Coverage Δ
packages/common/src/services/export-utilities.ts 100.00% <100.00%> (ø)
packages/excel-export/src/excelExport.service.ts 100.00% <100.00%> (ø)
packages/text-export/src/textExport.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a4cd3...cf96197. Read the comment docs.

@ghiscoding ghiscoding changed the title fix(exports): grid with colspan should be exported accordingly fix(exports): grid with colspan should export accordingly Apr 16, 2021
@ghiscoding ghiscoding merged commit e899fbb into master Apr 16, 2021
@ghiscoding ghiscoding deleted the bugfix/export-colspan branch April 16, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant