fix(editors): Composite Editor modal comp should work w/complex objects #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the composite editor component was partially working with complex object and this PR adds all missing piece for it to work entirely - we should be able to call `changeFormInputValue` with column and/or columnId and assume that the formValues will still be updated even with complex object(s) - add a new `changeFormValue` to update the `formValues` object directly without passing by an editor - also add a new and small dependency `deep-assign` since it was discovered that we can use spread to do deep assignment, this small lib does it nicely, else expose it through the Slicker.Utilities on the Vanilla Bundle
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 12659 12715 +56
Branches 4146 4169 +23
=========================================
+ Hits 12659 12715 +56
Continue to review full report at Codecov.
|
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changeFormInputValuewith column and/or columnId and assume that the formValues will still be updated even with complex object(s)changeFormValueto update theformValuesobject directly without passing by an editordeep-assignsince it was discovered that we can use spread to do deep assignment, this small lib does it nicely, else expose it through the Slicker.Utilities on the Vanilla Bundle