Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state): add Pinning (frozen) to Grid State & Presets #292

Merged
merged 7 commits into from
Mar 24, 2021

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Mar 20, 2021

TODOs

  • get Pinning from Grid State
  • use Pinning from grid options presets
  • add clearPinning and setPinning
  • add Cypress E2E tests to
    • save text search Filters with operators and redisplay them after changing Grid View dropdown
    • save & redisplay Pinning after changing Grid View dropdown
  • rename grid menu to "Unfreeze Columns/Rows" and in French "Dégeler les colonnes/rangées"

@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #292 (785c3af) into master (960f0c7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #292   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12486     12523   +37     
  Branches      4279      4287    +8     
=========================================
+ Hits         12486     12523   +37     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <ø> (ø)
packages/common/src/enums/gridStateType.enum.ts 100.00% <100.00%> (ø)
...ackages/common/src/extensions/gridMenuExtension.ts 100.00% <100.00%> (ø)
...kages/common/src/extensions/headerMenuExtension.ts 100.00% <100.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/gridState.service.ts 100.00% <100.00%> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960f0c7...785c3af. Read the comment docs.

@ghiscoding ghiscoding changed the title feat(state): add pinning(frozen) to Grid State & Presets feat(state): add Pinning (frozen) to Grid State & Presets Mar 20, 2021
@ghiscoding ghiscoding changed the title feat(state): add Pinning (frozen) to Grid State & Presets WIP - feat(state): add Pinning (frozen) to Grid State & Presets Mar 20, 2021
@ghiscoding ghiscoding changed the title WIP - feat(state): add Pinning (frozen) to Grid State & Presets feat(state): add Pinning (frozen) to Grid State & Presets Mar 22, 2021
- also clearPinning when doing a resetGrid
@ghiscoding ghiscoding merged commit ba703d8 into master Mar 24, 2021
@ghiscoding ghiscoding deleted the feat/grid-state-pinning branch March 24, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant