-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resources): add RxJS support into Slickgrid-Universal via external package #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
changed the title
feat(resources): add RxJS support into Slickgrid-Universal via external package
WIP - feat(resources): add RxJS support into Slickgrid-Universal via external package
Mar 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #280 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 209 212 +3
Lines 12523 12659 +136
Branches 4112 4146 +34
==========================================
+ Hits 12523 12659 +136
Continue to review full report at Codecov.
|
- because Observable/Subject are used in some of the Slickgrid-Universal interfaces, it would be better to keep same names as RxJS interfaces to avoid confusion even though it is still the facade that is in play
ghiscoding
changed the title
WIP - feat(resources): add RxJS support into Slickgrid-Universal via external package
feat(resources): add RxJS support into Slickgrid-Universal via external package
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add support of RxJS Observables with any Backend Services (like OData/GraphQL) which is the last missing piece for Angular-Slickgrid to finally use Slickgrid-Universal.
TODOs
@slickgrid-universal/common
packagecollectionAsync
collectionAsync
with Observable into the demo to test Filter/Editor