Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helpers): should be able to highlight first row (0) #268

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

ghiscoding
Copy link
Owner

  • calling highlightRow(0) was not highlighting the row when it should
  • fixes Aurelia-Slickgrid issue #527

- calling `highlightRow(0)` was not highlighting the row when it should
- fixes Aurelia-Slickgrid [issue #527](ghiscoding/aurelia-slickgrid#527)
@codecov
Copy link

codecov bot commented Feb 20, 2021

Codecov Report

Merging #268 (36409db) into master (20564a3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          209       209           
  Lines        12119     12119           
  Branches      4170      4170           
=========================================
  Hits         12119     12119           
Impacted Files Coverage Δ
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20564a3...36409db. Read the comment docs.

@ghiscoding ghiscoding merged commit a58be17 into master Feb 23, 2021
@ghiscoding ghiscoding deleted the bugfix/highlight-row-zero branch February 23, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant