Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): recreate header menu when adding column dynamically #257

Merged

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #257 (dad0b98) into master (619204e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #257   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          208       208           
  Lines        12008     12010    +2     
  Branches      4127      4128    +1     
=========================================
+ Hits         12008     12010    +2     
Impacted Files Coverage Δ
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619204e...dad0b98. Read the comment docs.

@ghiscoding ghiscoding merged commit 16c4984 into master Feb 3, 2021
@ghiscoding ghiscoding deleted the bugfix/header-menu-with-dynamically-added-column branch February 3, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant