Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): get pagination working in SF as well #24

Merged
merged 3 commits into from
Jul 22, 2020

Conversation

ghiscoding
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #24 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   99.58%   99.58%   +0.01%     
==========================================
  Files         184      184              
  Lines        9980     9982       +2     
  Branches     3292     3293       +1     
==========================================
+ Hits         9938     9940       +2     
  Misses         42       42              
Impacted Files Coverage Δ
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)
.../vanilla-bundle/src/components/slick-pagination.ts 100.00% <100.00%> (ø)
...ges/vanilla-bundle/src/services/binding.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1482e41...735301f. Read the comment docs.

@ghiscoding ghiscoding merged commit 1132f2e into master Jul 22, 2020
@ghiscoding ghiscoding deleted the fix/pagination-sf branch July 22, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants