Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): fix clear date & blank disabled field w/Composite Editor #235

Merged
merged 2 commits into from
Jan 13, 2021

Conversation

ghiscoding
Copy link
Owner

  • clear date was not working on the 2nd time, calling mass update once then saving and calling mass update again was not clearing the 2nd time around
  • the issue was because formValues was containing data of disabled fields even when these fields were not even touched, basically when disabling we shouldn't trigger the onCompositeEditorChange (and that was the issue)
  • also fixed the modal window to be disposed after we're done with saving massUpdate/massSelectionChange

- clear date was not working on the 2nd time, calling mass update once then saving and calling mass update again was not clearing the 2nd time around
- the issue was because formValues was containing data of disabled fields even when these fields were not even touched, basically when disabling we shouldn't trigger the onCompositeEditorChange (and that was the issue)
- also fixed the modal window to be disposed after we're done with saving massUpdate/massSelectionChange
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #235 (bb2318f) into master (16daa36) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #235   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          207       207           
  Lines        11919     11930   +11     
  Branches      4093      4094    +1     
=========================================
+ Hits         11919     11930   +11     
Impacted Files Coverage Δ
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/textEditor.ts 100.00% <100.00%> (ø)
...-component/src/slick-composite-editor.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16daa36...bb2318f. Read the comment docs.

@ghiscoding ghiscoding merged commit 9aac97d into master Jan 13, 2021
@ghiscoding ghiscoding deleted the bugfix/composite-editor-disable-fields branch January 13, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant