Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add console error if any of column def id includes dot #198

Merged

Conversation

ghiscoding
Copy link
Owner

  • all Editors/Filters are using the column definition id to add a css className for properly identifying the this editor/filter with a unique className, however if the columnId includes a dot then that becomes 2 class names in css and will cause issues, so it's better to advise the user from the start that his column definitions has some invalid Id(s).

- all Editors/Filters are using the column definition id to add a css className for properly identifying the this editor/filter with a unique className, however if the columnId includes a dot then that becomes 2 class names in css and will cause issues, so it's better to advise the user from the start that his column definitions has some invalid Id(s).
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #198 (1c6d25a) into master (6a7d980) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #198    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          206       206            
  Lines        11832     11834     +2     
  Branches      4041      3896   -145     
==========================================
+ Hits         11832     11834     +2     
Impacted Files Coverage Δ
packages/common/src/editors/checkboxEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/dualInputEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/floatEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/integerEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/selectEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/textEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/autoCompleteFilter.ts 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a7d980...1c6d25a. Read the comment docs.

@ghiscoding ghiscoding merged commit 6ee40af into master Dec 14, 2020
@ghiscoding ghiscoding deleted the bugfix/editors-filters-column-definition-with-dot branch December 14, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant