Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add "frozen" class to all slick-pane for easier styling #1752

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 28, 2024

  • prior to this PR, we needed to add frozen broder style on last header/columns, this was not only hard to style, it also wasn't styled correctly in the UI. by adding the "frozen" class directly on every left pane (when frozen column is enabled) makes it much easier to style the UI correctly
  • NOTE: since we can now style the frozen pane with 1 line, I deleted a bunch of SASS/CSS variables that are no longer necessary
    • $slick-frozen-preheader-row-border-right
    • $slick-frozen-header-row-border-right
    • $slick-frozen-filter-row-border-right

before

image

after

notice the blue line representing pinning is now properly displayed across the headers as well

image

Copy link

stackblitz bot commented Nov 28, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (8ccd0fa) to head (21d9b1f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1752     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         187     187             
  Lines       31121   31129      +8     
  Branches     9780    9783      +3     
========================================
+ Hits        31032   31040      +8     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 33a8a38 into master Nov 28, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/frozen-pane-style branch November 28, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant