Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setting Date filters dynamically shouldn't make body taller #1748

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 27, 2024

  • when setting filters dynamically, the calendar picker is appended to the body without being repositioning which is making the body taller and unnecessary scrollable
  • to fix this issue, we can simply preset hidden calendar picker at position 0,0

brave_E5rX3Q4jjW

- when setting filters dynamically, the calendar picker is appended to the body without being repositioning which is making the body taller and unnecessary scrollable
Copy link

stackblitz bot commented Nov 27, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (14c5cf1) to head (4f3ff92).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1748   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         187     187           
  Lines       30757   30757           
  Branches     9781    9781           
======================================
  Hits        30668   30668           
  Misses         89      89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 41e4317 into master Nov 27, 2024
7 checks passed
@ghiscoding ghiscoding deleted the bugfix/set-filter-dynamically-taller-body branch November 27, 2024 01:43
@ghiscoding ghiscoding changed the title fix: setting filter dynamically shouldn't make body taller fix: setting Date filters dynamically shouldn't make body taller Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant