Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hideColumnByIds wasn't hiding columns properly #1738

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Nov 9, 2024

tested a bit more after previous PR #1736 and found couple of small issues

  • calling hideColumnByIds() for multiple columns wasn't working correctly
  • also the options hideFromColumnPicker and hideFromGridMenu were incorrectly tied together meaning that when hideFromColumnPicker was enabled, it was also hiding them in the GridMenu as well which is wrong
  • lastly I've done a refactor to remove duplicate code of calling some grid commands when options autoResizeColumns and triggerEvent are enabled.

Copy link

stackblitz bot commented Nov 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (59a47b8) to head (e32d9f0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1738     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         187     187             
  Lines       30752   30747      -5     
  Branches     9777    9778      +1     
========================================
- Hits        30663   30658      -5     
  Misses         89      89             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit da89db4 into master Nov 9, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/multiple-hide-ids branch November 9, 2024 19:13
@ghiscoding ghiscoding mentioned this pull request Nov 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant