Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grouping): add onPreHeaderContextMenu for Column Picker usage #1580

Merged
merged 7 commits into from
Jun 20, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Jun 19, 2024

  • adding new events onPreHeaderContextMenu and onPreHeaderClick which is mostly to be able to open the Column Picker from either the regular column headers OR the Column Group from the Pre-Header when defined
  • also works with/without frozen column
  • Note: before calling the column picker, we need to make sure that the pre-header target element is in fact a column group, because if it's anything then we shouldn't open the column picker (e.g. draggable grouping dropzone)

TODOs

  • add unit tests
  • add Cypress tests

brave_tUchiggjIh

- adding new events `onPreHeaderContextMenu` and `onPreHeaderClick` which is mostly to be able to open the Column Picker from either the regular column headers OR the Column Group from the Pre-Header when defined
Copy link

stackblitz bot commented Jun 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (e5f00c1) to head (9fe3d2d).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1580     +/-   ##
========================================
+ Coverage    99.8%   99.8%   +0.1%     
========================================
  Files         198     198             
  Lines       21764   21773      +9     
  Branches     7148    7010    -138     
========================================
+ Hits        21703   21712      +9     
- Misses         55      61      +6     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit c742a83 into master Jun 20, 2024
6 checks passed
@ghiscoding ghiscoding deleted the feat/preheader-events-col-picker branch June 20, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant