Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add "Empty Data" warning message when grid is empty #155

Merged
merged 15 commits into from
Nov 9, 2020

Conversation

ghiscoding
Copy link
Owner

  • this is in fact a div element that is created and reposition inside the grid, the reason we do that is because we cannot put that text inside a cell because it has its cell boundary, so creating a div and position it over the grid is the best approach

Ghislain Beaulac and others added 8 commits November 6, 2020 11:09
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #155 (f591c0f) into master (9633d4a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          196       198    +2     
  Lines        11482     11556   +74     
  Branches      3770      3797   +27     
=========================================
+ Hits         11482     11556   +74     
Impacted Files Coverage Δ
packages/common/src/editors/dateEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/sliderEditor.ts 100.00% <100.00%> (ø)
...src/extensions/cellExternalCopyManagerExtension.ts 100.00% <100.00%> (ø)
...common/src/extensions/checkboxSelectorExtension.ts 100.00% <100.00%> (ø)
...s/common/src/extensions/rowMoveManagerExtension.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
...es/common/src/formatters/fakeHyperlinkFormatter.ts 100.00% <100.00%> (ø)
packages/common/src/interfaces/index.ts 100.00% <100.00%> (ø)
packages/common/src/services/extension.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/grid.service.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9633d4a...f591c0f. Read the comment docs.

@ghiscoding ghiscoding merged commit 13875b4 into master Nov 9, 2020
@ghiscoding ghiscoding deleted the feat/empty-data-warning branch November 9, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant