fix(filters): new filterPredicate
shouldn't break other column filters
#1531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filterPredicate
regressed with a new issue and that was not caught in the original PR. It had the indirect effect of breaking the other filter columns (I forgot to test that in the original PR), the issue was caused by the fact that calling areturn
within thefor
loop of all filters was cancelling all other filters in the loop because areturn
breaks the entire loop.return
when thefilterPredicate
returnsfalse
which mean that at point the row data context is officially filtered out and so stopping inspection of further filters does make sense at that point in time.Ta%30%
, it wasn't working correctly before and it is now equivalent to: StartsWith "Ta" and Contains "30" anywherebelow with the fix, other column filters now work (before the fix, the 2nd column filter wasn't doing anything)