Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editors): only open ms-select drop when exists #1525

Merged
merged 4 commits into from
May 11, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented May 11, 2024

  • when Row Selection in combo with single click open Editor, it was selecting the row and conflicting with the ms-select open, the issue was caused by a 0ms delay to open the ms-select editor and by the time it was calling open (after delay), the ms-select was in fact already destroyed because of the row selection and that caused a phantom select drop in top left corner that wasn't being removed and became an orphan DOM element (DOM leaking)

- when Row Selection in combo with single click open Editor, it was selecting the row and conflicting with the ms-select open, the issue was caused by a 0ms delay to open the ms-select editor and by the time it was calling open (after delay), the ms-select was in fact destroyed already because of the row selection causing a phantom select in top left corner that wasn't being removed and became an orphan element
Copy link

stackblitz bot commented May 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (a6dbf2c) to head (235a610).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1525    +/-   ##
=======================================
  Coverage    99.8%   99.8%            
=======================================
  Files         198     198            
  Lines       21616   21616            
  Branches     6949    7219   +270     
=======================================
  Hits        21555   21555            
  Misses         61      61            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 247daba into master May 11, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/ms-select-destroy-open branch May 11, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant