Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OData): sorting columns via id instead of field property name, fixes #1467 #1469

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

zewa666
Copy link
Contributor

@zewa666 zewa666 commented Apr 17, 2024

As mentioned in #1467 this fixes the OData Service to behave like the Graphql counterpart and store the columns id instead of field property, so that if the resulting gridState is persisted and re-applied, everything works as supposed

fixes #1467

Copy link

stackblitz bot commented Apr 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (a8e66f2) to head (de33b8d).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1469     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         199     199             
  Lines       21707   21706      -1     
  Branches     7262    7261      -1     
========================================
- Hits        21643   21642      -1     
  Misses         58      58             
  Partials        6       6             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ghiscoding ghiscoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for @jr01 review if he has a chance. Thanks

Also just so you know, there's also an Example 15 with OData demo which is a little less busy in terms of demo functionalities, the only difference is that it uses RxJS so it was mainly added to test that part. So if we ever want to add more stuff in the demo, then the Example 15 might be ok too. Cheers


cy.reload();

cy.window().its('localStorage').invoke('getItem', STORAGE_KEY)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that's cool, I didn't know about this kind of usage 👍🏻

@ghiscoding ghiscoding changed the title fix: odata sorting columns via id instead of field property fix(OData): sorting columns via id instead of field property name, fixes #1467 Apr 17, 2024
Copy link
Collaborator

@jr01 jr01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghiscoding ghiscoding merged commit 0a4d402 into ghiscoding:master Apr 18, 2024
7 checks passed
@ghiscoding
Copy link
Owner

Thanks for all contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gridstate sortcolumns field instead id property of column
3 participants