Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): don't try to strip tags on object input to calc cell width #1453

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ghiscoding
Copy link
Owner

  • when calculating cell content width, we parse the cell data to its Formatter if it exists but if it doesn't then in some cases it could return the entire dataContext and that would then throw when passed to stripTags() method, for these cases we can simply assume that the cell width is not calculable since the cell data is not a primitive result (not text, boolean,, number nor HTML)

- when calculating cell content width, we parse the cell data to its Formatter if it exists but if it doesn't then in some cases it could return the entire dataContext and that would then throw when passed to `stripTags()` method, for these cases we can simply assume that the cell width is not calculable since the cell data is not a primitive result (not text, boolean,, number nor HTML)
Copy link

stackblitz bot commented Apr 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.8%. Comparing base (cd33a9b) to head (c92cc40).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1453   +/-   ##
======================================
  Coverage    99.8%   99.8%           
======================================
  Files         199     199           
  Lines       21682   21682           
  Branches     6991    6992    +1     
======================================
  Hits        21618   21618           
  Misses         64      64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 5ab671b into master Apr 4, 2024
6 checks passed
@ghiscoding ghiscoding deleted the bugfix/calculate-cell-width branch April 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants