fix(common): switch to autocompleter-es to get ESM build
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- migrate to a temp package `autocompleter-es` until my opened PR on `autocompleter` is merged and hopefully release sometime in the future. - the goal of this switch is to have an ESM build so that we can remove it from `allowedCommonJsDependencies` (`angular.json`) for Angular-Slickgrid to have 1 less CJS dependency
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1449 +/- ##
======================================
Coverage 99.8% 99.8%
======================================
Files 199 199
Lines 21682 21682
Branches 7260 7260
======================================
Hits 21618 21618
+ Misses 64 58 -6
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autocompleter-esuntil my opened PR onautocompleteris merged and hopefully release sometime in the future.allowedCommonJsDependencies(angular.json) for Angular-Slickgrid to have 1 less CJS dependency