feat(core): rename SG editorClass & deprecate internalColumnEditor
#1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename SlickGrid `editor` to a new `editorClass` column property - this small rename will allow us to deprecate `internalColumnEditor` and simply tell users to use `editor` which will stay aligned with what the user defined in its column definitions (prior to this change, the users had to use `internalColumnEditor` after the grid was loaded, but with this change we no longer need to do that since it will simply keep the same editor definition assignment) - in summary `editor` is an editor definition and `editorClass` is a SlickGrid editor class (which is pulled from `editor.model`)
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1429 +/- ##
========================================
+ Coverage 99.8% 99.8% +0.1%
========================================
Files 199 199
Lines 21613 21614 +1
Branches 7230 7231 +1
========================================
+ Hits 21549 21550 +1
+ Misses 64 58 -6
- Partials 0 6 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
editorto a neweditorClasscolumn propertyinternalColumnEditorand simply tell users to useeditorwhich will stay aligned with what the user defined in its column definitions (prior to this change, the users had to useinternalColumnEditorafter the grid was loaded, but with this change we no longer need to do that since it will simply keep the same editor definition assignment)editoris an editor definition andeditorClassis a SlickGrid editor class (which is pulled fromeditor.model)TODOs