Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ExcelExport): migrate to Excel-Builder-Vanilla (ESM) #1383

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Feb 10, 2024

migrate to Excel-Builder-Vanilla which is a fork of excel-builder.js rewritten and modernized. It was rewritten as TypeScript, drops Q and Lodash dependencies and also swapped JSZip with fflate since it offers an ESM build with Tree Shaking support and better perf by using Web Workers.

So in summary, we get a much smaller build, better perf and 1 less CJS dependency to take care about, all win-win 🚀

Size Diff

file on disk on Windows OS, this is only for comparison and is expected to be much smaller with gzip

File before after diff % diff
SF Bundle Zip File 590Kb (604,738) 531Kb (544,733) 59Kb 9.92% smaller
GitHub Vite Demo Website 4.81Mb (5,048,893) 4.63Mb (4,857,095) 0.18Mb (or 192Kb) 3.8% smaller

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2562352) 99.8% compared to head (29a133e) 99.8%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1383     +/-   ##
========================================
- Coverage    99.8%   99.8%   -0.0%     
========================================
  Files         199     199             
  Lines       21566   21549     -17     
  Branches     7207    6934    -273     
========================================
- Hits        21503   21486     -17     
- Misses         57      63      +6     
+ Partials        6       0      -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding
Copy link
Owner Author

cc @zewa666 :)

@ghiscoding ghiscoding changed the title feat(ExcelExport): migrate to Excel-Export-Vanilla feat(ExcelExport): migrate to Excel-Export-Vanilla (ESM) Feb 11, 2024
@ghiscoding ghiscoding merged commit f3838b3 into master Feb 11, 2024
6 checks passed
@ghiscoding ghiscoding deleted the feat/excel-builder-vanilla branch February 11, 2024 04:23
@ghiscoding ghiscoding changed the title feat(ExcelExport): migrate to Excel-Export-Vanilla (ESM) feat(ExcelExport): migrate to Excel-Builder-Vanilla (ESM) Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant