perf(resizer): autosizeColumns is called too many times on page load
#1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when loading a new grid, we are calling `grid.autosizeColumns()` to resize the columns and while adding tests for that method I incidently discovered that it was being called multiple times on a page load (up to 6-8x times) but in reality there is no need to call it more than once or twice. - there is also no need to call the `autosizeColumns` if the grid dimension calculated by the Resizer Service are the same as the previously calculated dimensions - the updated code will never call `autosizeColumns` more than twice on a page load
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
========================================
+ Coverage 99.4% 99.4% +0.1%
========================================
Files 198 198
Lines 21284 21291 +7
Branches 7099 7101 +2
========================================
+ Hits 21144 21151 +7
Misses 140 140 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
autosizeColumns too many timesautosizeColumns is called too many times
ghiscoding
changed the title
autosizeColumns is called too many timesautosizeColumns is called too many times on page load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grid.autosizeColumns()to resize the columns and while adding tests for that method I incidently discovered that it was being called multiple times on a page load (up to 6-8x times) but in reality there is no need to call it more than once or twice.autosizeColumnsif the grid dimension calculated by the Resizer Service are the same as the previously calculated dimensionsautosizeColumnsmore than twice on a page load, however note that the method will always be called whenever the grid dimensions or columns get updated