fix: when onResizeStart return false it should stop
#1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when `onResizeStart` returns `false`, for example when editor `commitCurrentEdit()` fails, then the column resize shouldn't be allowed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1339 +/- ##
========================================
+ Coverage 99.4% 99.4% +0.1%
========================================
Files 198 198
Lines 21284 21285 +1
Branches 7097 7098 +1
========================================
+ Hits 21144 21145 +1
Misses 140 140 ☔ View full report in Codecov by Sentry. |
ghiscoding
added a commit
that referenced
this pull request
Jan 17, 2024
- when `onDragInit` returns `false` then the row or cell dragging shouldn't be allowed - this is similar to previous PR #1339
ghiscoding
added a commit
that referenced
this pull request
Jan 17, 2024
* fix: when `onDragInit` return false it should stop - when `onDragInit` returns `false` then the row or cell dragging shouldn't be allowed - this is similar to previous PR #1339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onResizeStartreturnsfalse, for example when editorcommitCurrentEdit()fails, then the column resize shouldn't be allowedslickgrid-universal/packages/common/src/core/slickGrid.ts
Lines 1906 to 1910 in bc4402a