Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(editors): disable editor when collectionAsync, re-enable after #132

Merged
merged 3 commits into from
Sep 29, 2020
Merged

feat(editors): disable editor when collectionAsync, re-enable after #132

merged 3 commits into from
Sep 29, 2020

Conversation

ghiscoding
Copy link
Owner

  • when using collectionAsync, we'll only get the collection afterward and during the waiting period our editor (DOM element) should be disabled and we will re-enable it only after getting the collection filled.

Ghislain Beaulac added 3 commits September 29, 2020 11:20
feat(editors): disable editor when collectionAsync, re-enable after
f9c6363 
- when using collectionAsync, we'll only get the collection afterward and during the waiting period our editor (DOM element) should be disabled and we will re-enable it only after getting the collection filled.
fix(core): update few npm packages to fix unit test failing
1cb7864
tests: tweak test to avoid flacky test
45e5f2d
@ghiscoding ghiscoding merged commit 75b10de into master Sep 29, 2020
@ghiscoding ghiscoding deleted the feat/disable-enable-editor-collection-async branch September 29, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ghiscoding