Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct argument type on setData() #1287

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

ghiscoding
Copy link
Owner

No description provided.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f08925c) 89.1% compared to head (1d79c1b) 91.0%.

Files Patch % Lines
packages/common/src/core/slickGrid.ts 84.3% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1287     +/-   ##
========================================
+ Coverage    89.1%   91.0%   +2.0%     
========================================
  Files         198     198             
  Lines       21349   21335     -14     
  Branches     7103    7098      -5     
========================================
+ Hits        19004   19405    +401     
+ Misses       2345    1930    -415     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 0b0b86c into master Dec 27, 2023
5 checks passed
@ghiscoding ghiscoding deleted the bugfix/slickgrid-setdata-arg-type branch December 27, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant