Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): add "hidden" to all controls/plugins with menu items #128

Merged
merged 23 commits into from
Sep 24, 2020

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Sep 21, 2020

  • requires core lib PR #532 to be merged and released

@codecov
Copy link

codecov bot commented Sep 21, 2020

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          195       196    +1     
  Lines        11193     11232   +39     
  Branches      3645      3655   +10     
=========================================
+ Hits         11193     11232   +39     
Impacted Files Coverage Δ
packages/common/src/constants.ts 100.00% <ø> (ø)
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <ø> (ø)
packages/common/src/editors/autoCompleteEditor.ts 100.00% <100.00%> (ø)
packages/common/src/editors/longTextEditor.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundDateFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/compoundInputFilter.ts 100.00% <100.00%> (ø)
...ackages/common/src/filters/compoundSliderFilter.ts 100.00% <100.00%> (ø)
packages/common/src/filters/filterUtilities.ts 100.00% <100.00%> (ø)
packages/common/src/services/filter.service.ts 100.00% <100.00%> (ø)
packages/common/src/services/sort.service.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc06ff8...52870ca. Read the comment docs.

Ghislain Beaulac and others added 21 commits September 21, 2020 14:24
- jQuery UI autocomplete was showing some errors of missing images in Salesforce, it seems to be due to missing jQuery UI styling, so we can just add minimal styling to fix this
- also fix openSearchListOnFocus that was not working correctly
@ghiscoding ghiscoding merged commit 99202de into master Sep 24, 2020
@ghiscoding ghiscoding deleted the feat/menu-item-hidden-property branch September 24, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant