fix: cell selection range with key combos were incorrect #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the previous key combo were incorrect, the new combo is the following - `Shift+Home` will select from current cell position to first cell horizontally - `Shift+End` will select from current cell position until the last cell horizontally - `Ctrl+Shift+Home` will select everything that is on the left side of current cell position and everything on top current position (horizontally left until first cell & vertically left until first row) - `Ctrl+Shift+End` will select everything that is on the right side of current cell position and everything on bottom current position (horizontally right until last cell & vertically right until last row)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1244 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 246 246
Lines 17305 17319 +14
Branches 6257 6260 +3
=========================================
+ Hits 17305 17319 +14 ☔ View full report in Codecov by Sentry. |
ghiscoding
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the previous key combo were incorrect, the new combo is the following
Shift+Homewill select from current cell position to first cell horizontallyShift+Endwill select from current cell position until the last cell horizontallyCtrl+Shift+Homewill select everything that is on the left side of current cell position and everything on top current position (horizontally left until first cell & vertically left until first row)Ctrl+Shift+Endwill select everything that is on the right side of current cell position and everything on bottom current position (horizontally right until last cell & vertically right until last row)The other key combos (with PageUp/PageDown/ArrowLeft/ArrowRight) remains the same
TODOS
Shift+Home
Shift+End
Ctrl+Shift+Home
Ctrl+Shift+End